[coreboot-gerrit] Change in coreboot[master]: amd/pi/hudson: Add LPC IO decode enable function

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/19160 )

Change subject: amd/pi/hudson: Add LPC IO decode enable function
......................................................................


Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/19160/7/src/southbridge/amd/pi/hudson/hudson.h
File src/southbridge/amd/pi/hudson/hudson.h:

Line 170: void lpc_wideio_16_window(uint16_t base);
> IS there a reason to guard these declarations behind __PRE_RAM__ ? It's cau
As with the other functions that are guarded, it is in the early_setup.c, which is only built in the romstages. I suppose the this is a remnant of older ways of doing things before the linker would strip out unused functions. These could probably be combined now.


-- 
To view, visit https://review.coreboot.org/19160
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2bed3a99180188101e00b4431d634227e488cbda
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes