[coreboot-gerrit] Change in coreboot[master]: [WIP]soc/intel/common/block: Add Intel PMC support

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19349 )

Change subject: [WIP]soc/intel/common/block: Add Intel PMC support
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/19349/2/src/soc/intel/common/block/include/intelblocks/pmc.h
File src/soc/intel/common/block/include/intelblocks/pmc.h:

PS2, Line 4:  * Copyright 2017 Intel Corporation.
i guess one (C) i missing


PS2, Line 27: void pmc_enable_pm1_control(uint32_t mask);
            : void pmc_disable_pm1_control(uint32_t mask);
can we have single function with bool argument as enable/disable

in this way, we may avoid so many API


-- 
To view, visit https://review.coreboot.org/19349
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3d96fc23a98c30e8ea0969a7be09d217eeaa889
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes