[coreboot-gerrit] Change in coreboot[master]: x86/acpi: Use initialized VBIOS in VFCT table

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/19383 )

Change subject: x86/acpi: Use initialized VBIOS in VFCT table
......................................................................


Patch Set 1:

(3 comments)

You could add a new method to do all the verifications.

https://review.coreboot.org/#/c/19383/1/src/device/pci_rom.c
File src/device/pci_rom.c:

Line 195: 		run_rom = (struct rom_header *)PCI_VGA_RAM_IMAGE_START;
You should check run_rom->signature first, to make sure it's an option rom.


Line 197: 					+ le32_to_cpu(run_rom->data));
Please fix ident: Tabs are 8 blanks in width.


Line 198: 		if (device->device == rom_data->device
Please check if it's an VGA option rom.


-- 
To view, visit https://review.coreboot.org/19383
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5be7e1562bde51800c5b0e704c79812d85bcf362
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes