[coreboot-gerrit] Change in coreboot[master]: mediatek/mt8173: Add EINT support

[Daniel Kurtz (Code Review)]

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/19362 )

Change subject: mediatek/mt8173: Add EINT support
......................................................................


Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/19362/1//COMMIT_MSG
Commit Message:

Line 11: Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
> Please move that directly below the Change-Id line.
Done


PS1, Line 15: deptcharge
> depthcharge
Done


PS1, Line 16: irq
> IRQ
Done


https://review.coreboot.org/#/c/19362/1/src/soc/mediatek/mt8173/include/soc/gpio.h
File src/soc/mediatek/mt8173/include/soc/gpio.h:

Line 135: 		    enum eint_sense_polarity type);
> I made some comments in the sister CL on chromium. commenting the functions
Done


-- 
To view, visit https://review.coreboot.org/19362
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d52591661a5a74ec1fd9a081f606f0a08a3a6ab
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes