[coreboot-gerrit] Change in coreboot[master]: oak/mediatek/mt8173: Enable Dual DSI output for Rowan

[Daniel Kurtz (Code Review)]

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/19361 )

Change subject: oak/mediatek/mt8173: Enable Dual DSI output for Rowan
......................................................................


Patch Set 1:

(2 comments)

> (2 comments)
 > 
 > Very nice. Two things.
 > 
 > 1.  For reviewers a reference to the used datasheet would be nice.

Hmm.  I don't have any way of doing that, unfortunately.

 > 2.  Normally, it’s preferred to split such commits into two. The
 > first adds support to `soc/mediatek/mt8173`, and the second adapts
 > `google/oak`. That also makes the prefix in the commit message
 > summary easier.

Makes sense, will do.

https://review.coreboot.org/#/c/19361/1//COMMIT_MSG
Commit Message:

PS1, Line 10: Add dual-DSI support to mt8173/, and wire it up for use on Rowan.
> Please don’t add line breaks after a sentence. If it’s supposed to be a new
Done


PS1, Line 12: Signed-off-by: Jitao Shi <jitao.shi at mediatek.com>
            : Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
> Please move that directly below the Change-Id line.
Done


-- 
To view, visit https://review.coreboot.org/19361
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id47dfd7d9e98689b54398fc8d9142336b41dc29f
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes