[coreboot-gerrit] Change in coreboot[master]: google/oak: support cr50 over i2c on rowan

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19364 )

Change subject: google/oak: support cr50 over i2c on rowan
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19364/1/src/mainboard/google/oak/chromeos.c
File src/mainboard/google/oak/chromeos.c:

Line 59: int tis_plat_irq_status(void)
> Technically this has the same CONFIG_CHROMEOS issue Aaron mentioned in the 
edit: Also, when you do that, it's easy to guard that file by Kconfig in the Makefile without needing an #ifdef.


-- 
To view, visit https://review.coreboot.org/19364
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6cdd0e39e4ac86538f27f322c55c329179ee084
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes