[coreboot-gerrit] Change in coreboot[master]: include: Add xmalloc, xzmalloc and dma routines

Lee Leahy (Code Review) gerrit at coreboot.org
Wed Apr 19 21:11:20 CEST 2017


Lee Leahy has posted comments on this change. ( https://review.coreboot.org/19207 )

Change subject: include: Add xmalloc, xzmalloc and dma routines
......................................................................


Patch Set 5:

(5 comments)

https://review.coreboot.org/#/c/19207/5/src/commonlib/include/commonlib/stdlib.h
File src/commonlib/include/commonlib/stdlib.h:

PS5, Line 35: printk
> Should include console.h then. And then stdio.h if not coreboot.
Done


PS5, Line 41: malloc
> need to #include stdlib.h
Done


PS5, Line 46: halt
> need to #include halt.h. But if this header was supposed to be used in util
Done


PS5, Line 56: memset
> You need to #include string.h for this.
Done


PS5, Line 61: size_t
> need #include stddef.h
Done


-- 
To view, visit https://review.coreboot.org/19207
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2eb2ca143b0538bdd1863e628af4c1948bc0f8c
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list