[coreboot-gerrit] Change in coreboot[master]: mainboard/google/poppy: Provide memory configuration variant...

Furquan Shaikh (Code Review) gerrit at coreboot.org
Wed Apr 19 19:16:17 CEST 2017


Hello Aaron Durbin, build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19325

to look at the new patch set (#6).

Change subject: mainboard/google/poppy: Provide memory configuration variant API
......................................................................

mainboard/google/poppy: Provide memory configuration variant API

Add support for memory configuration by providing weak implementation
from the baseboard. All SPD files are present under spd/
directory. SPD_SOURCES must be provided by the variants to ensure that
required SPD hex files are included in the SPD binary.

BUG=b:37375693

Change-Id: Ic9bcc03d5a35bebd14061680f264ac072b3c0634
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/mainboard/google/poppy/Makefile.inc
M src/mainboard/google/poppy/romstage.c
M src/mainboard/google/poppy/spd/Makefile.inc
D src/mainboard/google/poppy/spd/spd.c
D src/mainboard/google/poppy/spd/spd.h
M src/mainboard/google/poppy/variants/baseboard/Makefile.inc
M src/mainboard/google/poppy/variants/baseboard/include/baseboard/variants.h
A src/mainboard/google/poppy/variants/baseboard/memory.c
A src/mainboard/google/poppy/variants/poppy/Makefile.inc
9 files changed, 196 insertions(+), 200 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/19325/6
-- 
To view, visit https://review.coreboot.org/19325
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic9bcc03d5a35bebd14061680f264ac072b3c0634
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: YH Lin <yueherngl at google.com>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list