[coreboot-gerrit] Change in coreboot[master]: mainboard/google/poppy: Provide baseboard and variant concepts

Furquan Shaikh (Code Review) gerrit at coreboot.org
Wed Apr 19 19:16:17 CEST 2017


Hello Aaron Durbin, build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19322

to look at the new patch set (#6).

Change subject: mainboard/google/poppy: Provide baseboard and variant concepts
......................................................................

mainboard/google/poppy: Provide baseboard and variant concepts

In order to be able to share code across different poppy variants,
provide the concept of baseboard and variants. New directory layout:

variants/baseboard - code
variants/baseboard/include/baseboard - headers
variants/poppy - code
variants/poppy/include/variant - headers

New boards would then add themselves under their board name within
"variants" directory.

This is purely an organizational change.

BUG=b:37375693

Change-Id: If6c1c5f479cfffe768abf27495d379744104e2dc
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/mainboard/google/poppy/Kconfig
M src/mainboard/google/poppy/Makefile.inc
M src/mainboard/google/poppy/bootblock.c
M src/mainboard/google/poppy/chromeos.c
M src/mainboard/google/poppy/dsdt.asl
M src/mainboard/google/poppy/ec.c
M src/mainboard/google/poppy/ramstage.c
M src/mainboard/google/poppy/smihandler.c
M src/mainboard/google/poppy/spd/spd.c
R src/mainboard/google/poppy/variants/baseboard/devicetree.cb
R src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/dptf.asl
R src/mainboard/google/poppy/variants/baseboard/include/baseboard/ec.h
R src/mainboard/google/poppy/variants/baseboard/include/baseboard/gpio.h
A src/mainboard/google/poppy/variants/poppy/include/variant/acpi/dptf.asl
A src/mainboard/google/poppy/variants/poppy/include/variant/ec.h
A src/mainboard/google/poppy/variants/poppy/include/variant/gpio.h
16 files changed, 88 insertions(+), 16 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/19322/6
-- 
To view, visit https://review.coreboot.org/19322
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If6c1c5f479cfffe768abf27495d379744104e2dc
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: YH Lin <yueherngl at google.com>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list