[coreboot-gerrit] Change in coreboot[master]: drivers/intel/mipi_camera: Add MIPI CSI camera SSDT generator
V Sowmya (Code Review)
gerrit at coreboot.org
Wed Apr 19 16:14:08 CEST 2017
V Sowmya has posted comments on this change. ( https://review.coreboot.org/18967 )
Change subject: drivers/intel/mipi_camera: Add MIPI CSI camera SSDT generator
......................................................................
Patch Set 6:
(2 comments)
> (2 comments)
>
> `checkpatch.pl` output:
>
> ```
> + util/lint/checkpatch.pl --no-signoff -q -
> ERROR: space required before the open brace '{'
> #84: FILE: src/drivers/intel/mipi_camera/camera.c:58:
> + if (config->device_type == INTEL_ACPI_CAMERA_SENSOR){
>
> total: 1 errors, 0 warnings, 215 lines checked
> + true
> ```
>
> [1] https://qa.coreboot.org/job/coreboot-checkpatch/8163/console
https://review.coreboot.org/#/c/18967/6/src/drivers/intel/mipi_camera/camera.c
File src/drivers/intel/mipi_camera/camera.c:
PS6, Line 84: .read_resources = DEVICE_NOOP,
: .set_resources = DEVICE_NOOP,
: .enable_resources = DEVICE_NOOP,
: .acpi_name = &camera_acpi_name,
: .acpi_fill_ssdt_generator = &camera_fill_ssdt,
> Use tabs for alignment, or don’t align the is-equal signs at all?
Done
PS6, Line 97: Intel Camera Device
> Add *MIPI* in here too?
Done
--
To view, visit https://review.coreboot.org/18967
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief9e56d12b64081897613bf1c7abcdf915470b99
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list