[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add Intel common FAST_SPI code

[Barnali Sarkar (Code Review)]

Barnali Sarkar has posted comments on this change. ( https://review.coreboot.org/18557 )

Change subject: soc/intel/common/block: Add Intel common FAST_SPI code
......................................................................


Patch Set 25:

(11 comments)

https://review.coreboot.org/#/c/18557/25/src/soc/intel/common/block/fast_spi/Makefile.inc
File src/soc/intel/common/block/fast_spi/Makefile.inc:

PS25, Line 8: y
> You don't need 2 layers of ifeq. You can just do:
yes, make sense. will change it.


https://review.coreboot.org/#/c/18557/25/src/soc/intel/common/block/fast_spi/fast_spi.c
File src/soc/intel/common/block/fast_spi/fast_spi.c:

Line 30: /* Helper to create a FAST_SPI context on API entry. */
> Please move all the spi_flash support to its own compilation unit.
Hi Aaron,
Sorry, I didnt get this comment.
What other spi_flash support do you want to add here in this module?


Line 103: /* Read register from the FAST_SPI flash controller. 'reg' is the register offset. */
> > 80
will fix


PS25, Line 107:  4
> sizeof(uint32_t)
ok


Line 111: uint32_t fast_spi_flash_ctrlr_reg_read(uint16_t reg)
> Does this need to be exposed to the outside world?
No, this can be static as well. will change it.


PS25, Line 121: 4
> sizeof(uint32_t)
ok


Line 219: unsigned int fast_spi_crop_chunk(unsigned int cmd_len, unsigned int buf_len)
> Where is this function being used?
Yes, this function isn't being used anywhere. Will remove it.


PS25, Line 331: nuclea
> Please drop this nuclear thing. It's not reflecting anything useful in the 
ok


Line 360: 
> We need to check that spi_slave->bus matches the SoC bus this spi controlle
will check this


PS25, Line 535: (bios_end - bios_start)
> parens not needed.
ok


https://review.coreboot.org/#/c/18557/25/src/soc/intel/common/block/include/intelblocks/fast_spi.h
File src/soc/intel/common/block/include/intelblocks/fast_spi.h:

PS25, Line 36: early_
> fast_spi_ prefix.
will fix


-- 
To view, visit https://review.coreboot.org/18557
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I046e3b30c8efb172851dd17f49565c9ec4cb38cb
Gerrit-PatchSet: 25
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Pratikkumar Prajapati <pratikkumar.v.prajapati at intel.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes