[coreboot-gerrit] Change in coreboot[master]: NOT_FOR_MERGE amd/pi/00670F00: fix up stack after verstage

Marshall Dawson (Code Review) gerrit at coreboot.org
Wed Apr 19 04:01:32 CEST 2017


Marshall Dawson has uploaded a new change for review. ( https://review.coreboot.org/19358 )

Change subject: NOT_FOR_MERGE amd/pi/00670F00: fix up stack after verstage
......................................................................

NOT_FOR_MERGE amd/pi/00670F00: fix up stack after verstage

To be squashed if the current romstage-after-verstage arrangement is
kept.

The new toolchain causes aligned instructions to be emitted and the
stack cannot support this without some adjustment.

Change-Id: I39bc33f87462ba47deec9637980a5344b7b39ac8
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
---
M src/cpu/amd/pi/romstage_after_verstage.S
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/19358/1

diff --git a/src/cpu/amd/pi/romstage_after_verstage.S b/src/cpu/amd/pi/romstage_after_verstage.S
index a89c20a..66bb086 100644
--- a/src/cpu/amd/pi/romstage_after_verstage.S
+++ b/src/cpu/amd/pi/romstage_after_verstage.S
@@ -18,6 +18,11 @@
 .text
 .global car_stage_entry
 car_stage_entry:
+	pushl	$0x0
+	pushl	$0x0
+	pushl	$0x0
+	pushl	$0x0
+	and		$0xfffffff0, %esp
 	call	romstage_after_verstage
 
 	#include "after_raminit.S"

-- 
To view, visit https://review.coreboot.org/19358
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I39bc33f87462ba47deec9637980a5344b7b39ac8
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>



More information about the coreboot-gerrit mailing list