[coreboot-gerrit] Change in coreboot[master]: cpu/amd/pi: Split CAR setup for use in multiple stages

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/18437 )

Change subject: cpu/amd/pi: Split CAR setup for use in multiple stages
......................................................................


Patch Set 10:

(1 comment)

> Are you planning to address my comments in this patch?

Yes.  Not done yet.

https://review.coreboot.org/#/c/18437/10//COMMIT_MSG
Commit Message:

PS10, Line 9: commit e6af4be
> Please add the summary after it in parentheses.
Done, sort of.


-- 
To view, visit https://review.coreboot.org/18437
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9fe53ca1fd6b1edd4d5e072849f3962c8bc95df0
Gerrit-PatchSet: 10
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes