[coreboot-gerrit] Change in coreboot[master]: google/gru: change kevin boot-time center logic voltage to 9...

[Julius Werner (Code Review)]

Hello Patrick Georgi,

I'd like you to do a code review.  Please visit

    https://review.coreboot.org/19357

to review the following change.


Change subject: google/gru: change kevin boot-time center logic voltage to 925mV
......................................................................

google/gru: change kevin boot-time center logic voltage to 925mV

Kevin's center logic isn't super clean so it needs 925 mV for center
logic.  All newer gru variants only need 900 mV.

BRANCH=gru
BUG=b:37429075
TEST=Reboot tests

Change-Id: I8c3bd6c245700b23c27cd5758c35c9993f801cb4
Signed-off-by: Douglas Anderson <dianders at chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/479463
Reviewed-by: Julius Werner <jwerner at chromium.org>
---
M src/mainboard/google/gru/romstage.c
1 file changed, 7 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/19357/1

diff --git a/src/mainboard/google/gru/romstage.c b/src/mainboard/google/gru/romstage.c
index 4ea5318..7c0dfd0 100644
--- a/src/mainboard/google/gru/romstage.c
+++ b/src/mainboard/google/gru/romstage.c
@@ -38,7 +38,13 @@
 {
 	pwm_regulator_configure(PWM_REGULATOR_GPU, 900);
 	pwm_regulator_configure(PWM_REGULATOR_BIG, 900);
-	pwm_regulator_configure(PWM_REGULATOR_CENTERLOG, 900);
+
+	/* Kevin's logic rail has some ripple, so up the voltage a bit */
+	if (IS_ENABLED(CONFIG_BOARD_GOOGLE_KEVIN))
+		pwm_regulator_configure(PWM_REGULATOR_CENTERLOG, 925);
+	else
+		pwm_regulator_configure(PWM_REGULATOR_CENTERLOG, 900);
+
 	/* Allow time for the regulators to settle */
 	udelay(500);
 }

-- 
To view, visit https://review.coreboot.org/19357
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c3bd6c245700b23c27cd5758c35c9993f801cb4
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>