[coreboot-gerrit] Change in coreboot[master]: mma : update mma setup script for v2.1018

[Pratikkumar V Prajapati (Code Review)]

Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/19259 )

Change subject: mma : update mma setup script for v2.1018
......................................................................


Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/19259/1//COMMIT_MSG
Commit Message:

PS1, Line 7: mma :
> Please remove the space. See `git log` how it’s done in most commits.
Done


PS1, Line 9: MMA blobs internal version 2.1018 adds more tests.
           : This patch updates the script to accommodate that change.
           : MMA blobs are part of chrome private repository.
> Please don’t add a line break after each sentence. If it is indeed an enume
Done


PS1, Line 11: MMA blobs are part of chrome private repository.
> Please add an URL anyway.
Which URL?


https://review.coreboot.org/#/c/19259/1/util/mma/mma_setup_test.sh
File util/mma/mma_setup_test.sh:

PS1, Line 29: printf "MMA blobs version : 2.1018\n"
> Can’t you add a separate version command? This should have been split into 
(1) I want users of this script to know the version and all supported MMA blobs if they enter wrong arguments or no args.

(2) 
I am updating script for this new version of blobs only. Any reason i should have separate commits?


-- 
To view, visit https://review.coreboot.org/19259
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff660fdfdfcd7acc3820c5550740276be6213877
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes