[coreboot-gerrit] Change in coreboot[master]: libpayload/drivers/serial/8250: Flush serial input buffer on...

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19345 )

Change subject: libpayload/drivers/serial/8250: Flush serial input buffer on init
......................................................................


Patch Set 1:

>  feel like we've already hit this issue before and made a fix. However, I can't recall at what layer of the stack.

I see that we have done this in depthcharge and in libpayload its done in keyboard.c. As Paul suggested, I am thinking of actually doing this within the console_add_input_driver itself so that the console layer can take care of it rather than each driver having to do it.

-- 
To view, visit https://review.coreboot.org/19345
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46f1b6715ccf6418f5b2c741bf90db2ece26a60d
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No