[coreboot-gerrit] Change in coreboot[master]: libpayload/drivers/serial/8250: Flush serial input buffer on...

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded a new change for review. ( https://review.coreboot.org/19345 )

Change subject: libpayload/drivers/serial/8250: Flush serial input buffer on init
......................................................................

libpayload/drivers/serial/8250: Flush serial input buffer on init

During serial console initialization, flush out serial input buffer to
avoid interpreting any stale key presses before libpayload is run.

BUG=b:37273808
TEST=Verified that any key presses in serial console before payload is
up do not have any effect after the payload starts running.

Change-Id: I46f1b6715ccf6418f5b2c741bf90db2ece26a60d
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M payloads/libpayload/drivers/serial/8250.c
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/19345/1

diff --git a/payloads/libpayload/drivers/serial/8250.c b/payloads/libpayload/drivers/serial/8250.c
index 1fcf36d..fe02c01 100644
--- a/payloads/libpayload/drivers/serial/8250.c
+++ b/payloads/libpayload/drivers/serial/8250.c
@@ -137,10 +137,13 @@
 		return;
 
 	serial_init();
+	serial_hardware_is_present = 1;
+
+	while (serial_havechar())
+		serial_getchar();
 
 	console_add_input_driver(&consin);
 	console_add_output_driver(&consout);
-	serial_hardware_is_present = 1;
 }
 
 void serial_putchar(unsigned int c)

-- 
To view, visit https://review.coreboot.org/19345
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I46f1b6715ccf6418f5b2c741bf90db2ece26a60d
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>