[coreboot-gerrit] Change in coreboot[master]: arch/x86/acpi: Allow "transparent" ACPI device names

[Timothy Pearson (Code Review)]

Timothy Pearson has submitted this change and it was merged. ( https://review.coreboot.org/19281 )

Change subject: arch/x86/acpi: Allow "transparent" ACPI device names
......................................................................


arch/x86/acpi: Allow "transparent" ACPI device names

Certain devices, such as the northbridge on AMD Opteron systems,
do not require a node in the ACPI device path.  Allow such devices
to be passed over by the ACPI path generator if the device-specific
ACPI name function returns a zero-length (non-NULL) string.

Change-Id: Iffffc9a30b395b0bd6d60e411439a437e89f554e
Signed-off-by: Timothy Pearson <tpearson at raptorengineering.com>
Reviewed-on: https://review.coreboot.org/19281
Tested-by: build bot (Jenkins)
Tested-by: Raptor Engineering Automated Test Stand <noreply at raptorengineeringinc.com>
Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
M src/arch/x86/acpi_device.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Aaron Durbin: Looks good to me, approved
  Raptor Engineering Automated Test Stand: Verified
  Duncan Laurie: Looks good to me, approved
  build bot (Jenkins): Verified



diff --git a/src/arch/x86/acpi_device.c b/src/arch/x86/acpi_device.c
index f4f1c4c..49439cc 100644
--- a/src/arch/x86/acpi_device.c
+++ b/src/arch/x86/acpi_device.c
@@ -113,7 +113,9 @@
 
 	/* Fill in the path from the root device */
 	next += snprintf(buf + next, buf_len - next, "%s%s",
-			 dev->path.type == DEVICE_PATH_ROOT ? "" : ".", name);
+			 (dev->path.type == DEVICE_PATH_ROOT
+				|| (strlen(name) == 0)) ?
+					"" : ".", name);
 
 	return next;
 }

-- 
To view, visit https://review.coreboot.org/19281
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iffffc9a30b395b0bd6d60e411439a437e89f554e
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Timothy Pearson <tpearson at raptorengineering.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Raptor Engineering Automated Test Stand <noreply at raptorengineeringinc.com>
Gerrit-Reviewer: Timothy Pearson <tpearson at raptorengineering.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: coreboot org <coreboot.org at gmail.com>