[coreboot-gerrit] Change in coreboot[master]: amd/pi/00670F00: Change to early cbmem init

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/18433 )

Change subject: amd/pi/00670F00: Change to early cbmem init
......................................................................


Patch Set 11:

(1 comment)

https://review.coreboot.org/#/c/18433/11/src/northbridge/amd/pi/00670F00/memmap.c
File src/northbridge/amd/pi/00670F00/memmap.c:

Line 76:  * no opportunity for the mainboard to override it.
> Well that's a fault in agesawrapper.c waiting to be fixed, letting platform
> In current code, board can still override CfgUmaAlignment to save MTRRs?

I tried overriding that value but it looks like the precompiled PI doesn't honor that value.  I wasn't able to misalign it, but I was checking where user options are dumped.


-- 
To view, visit https://review.coreboot.org/18433
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1c22a15752a07eebf39530ba8549ef1f74265ec
Gerrit-PatchSet: 11
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Ronald Minnich <rminnich at google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes