[coreboot-gerrit] Change in coreboot[master]: nb/pineview/raminit: Fix raminit failing on hot reset path
Martin Roth (Code Review)
gerrit at coreboot.org
Mon Apr 17 18:23:34 CEST 2017
Martin Roth has posted comments on this change. ( https://review.coreboot.org/19337 )
Change subject: nb/pineview/raminit: Fix raminit failing on hot reset path
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/19337/1/src/northbridge/intel/pineview/raminit.c
File src/northbridge/intel/pineview/raminit.c:
PS1, Line 572: if (s->boot_path != BOOT_PATH_RESET) {
Just return so you don't have to indent everything?
PS1, Line 581:
change back to space?
--
To view, visit https://review.coreboot.org/19337
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f7e5c2958df29a96cdf856ade2f4f33707ad362
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list