[coreboot-gerrit] Change in coreboot[master]: superio/ite/it8728f: Add fancontrol

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19293 )

Change subject: superio/ite/it8728f: Add fancontrol
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/19293/3/src/superio/ite/it8728f/it8728f_hwm.c
File src/superio/ite/it8728f/it8728f_hwm.c:

Line 87: 	/* configure automatic fan control */
Since all of the conf values will be 0 until they're enabled in the devicetree, should something be tested to see if this code should be run?  I assume that changing all of these to 0 might have some negative effect.

Maybe add a conf value of use_fan_control or something?


-- 
To view, visit https://review.coreboot.org/19293
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf0c8908ba5ad6ff552b8302bffc638aa9052941
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rudolf Marek <r.marek at assembler.cz>
Gerrit-Reviewer: Sergej Ivanov <getinaks at gmail.com>
Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes