[coreboot-gerrit] Change in coreboot[master]: nb/intel/x4x/raminit: Refactor receive enable calibration

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18692 )

Change subject: nb/intel/x4x/raminit: Refactor receive enable calibration
......................................................................


Patch Set 11:

(3 comments)

Thanks a lot for going through this!

https://review.coreboot.org/#/c/18692/11/src/northbridge/intel/x4x/rcven.c
File src/northbridge/intel/x4x/rcven.c:

Line 132: 		if (timing->tap > 14)
> That's an overflow and it's ok to return the 15 since it's
nice find! Looks like code got that wrong previously too.

So a counter variable variable would be needed here.


PS11, Line 158: low
> `high`
ok.


Line 234: 	timing->pi = 3;
> Again, decreasing tap and increasing pi should be drawn together.
ok


-- 
To view, visit https://review.coreboot.org/18692
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c970455e609d3ce96a262cbf110336a2079da4d
Gerrit-PatchSet: 11
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Damien Zammit <damien at zamaudio.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: coreboot org <coreboot.org at gmail.com>
Gerrit-HasComments: Yes