[coreboot-gerrit] Change in coreboot[master]: nb/intel/pineview/raminit: Fix CONFIG_DEBUG_RAM_SETUP=y not ...

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded a new change for review. ( https://review.coreboot.org/19336 )

Change subject: nb/intel/pineview/raminit: Fix CONFIG_DEBUG_RAM_SETUP=y not compiling
......................................................................

nb/intel/pineview/raminit: Fix CONFIG_DEBUG_RAM_SETUP=y not compiling

The function decode_spd uses undeclared variables and an incorrectly
initialized array.

Change-Id: Ib45a8b2946c04c270e29524675b1f09d491d282b
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/northbridge/intel/pineview/raminit.c
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/19336/1

diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c
index e1d23a5..5c8b7e0 100644
--- a/src/northbridge/intel/pineview/raminit.c
+++ b/src/northbridge/intel/pineview/raminit.c
@@ -109,7 +109,7 @@
 	return smbus_read_byte(device, address);
 }
 
-static int decode_spd(struct dimminfo *d)
+static int decode_spd(struct dimminfo *d, int i)
 {
 	d->type = 0;
 	if (d->spd_data[20] == 0x2) {
@@ -136,7 +136,7 @@
 	d->tWR = d->spd_data[36];
 	d->ranks = d->sides; // XXX
 #if CONFIG_DEBUG_RAM_SETUP
-	const char *ubso[] = { {"UB"}, {"SO"} };
+	const char *ubso[2] = { "UB", "SO" };
 #endif
 	PRINTK_DEBUG("%s-DIMM %d\n", &ubso[d->type][0], i);
 	PRINTK_DEBUG("  Sides     : %d\n", d->sides);

-- 
To view, visit https://review.coreboot.org/19336
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib45a8b2946c04c270e29524675b1f09d491d282b
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>