[coreboot-gerrit] Change in coreboot[master]: drivers/intel/mipi_camera: Add MIPI CSI camera SSDT generator

[V Sowmya (Code Review)]

V Sowmya has posted comments on this change. ( https://review.coreboot.org/18967 )

Change subject: drivers/intel/mipi_camera: Add MIPI CSI camera SSDT generator
......................................................................


Patch Set 4:

(3 comments)

> (3 comments)

https://review.coreboot.org/#/c/18967/4/src/drivers/intel/mipi_camera/Kconfig
File src/drivers/intel/mipi_camera/Kconfig:

PS4, Line 6: CLDB
> CAMD?
Removed CLDB.


https://review.coreboot.org/#/c/18967/4/src/drivers/intel/mipi_camera/chip.h
File src/drivers/intel/mipi_camera/chip.h:

Line 39: 	uint8_t sensor_card_sku;		/* CRD Board type*/
> space before */
Done


PS4, Line 93: time
> is this in msec or usec or sec? Can you also update variable name according
Done


-- 
To view, visit https://review.coreboot.org/18967
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief9e56d12b64081897613bf1c7abcdf915470b99
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes