[coreboot-gerrit] Change in coreboot[master]: northbridge/haswell: clean up native graphics init code

Matt DeVillier (Code Review) gerrit at coreboot.org
Mon Apr 17 01:08:23 CEST 2017


Hello build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19327

to look at the new patch set (#3).

Change subject: northbridge/haswell: clean up native graphics init code
......................................................................

northbridge/haswell: clean up native graphics init code

Clean up NGI code now that libgfxinit has replaced old C code:

- replace #if preprocessor guards with if (IS_ENABLED(...))
- don't guard variable declarations
- remove code that would only be executed for old NGI / isn't
  used by libgfxinit

Test: boot google/wolf with VBIOS, NGI, and UEFI/GOP video init,
observe payload and pre-OS graphics display functional.

Change-Id: I96e74f49ea70e09cbac6f8af561de3e18fa7d260
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/northbridge/intel/haswell/gma.c
1 file changed, 19 insertions(+), 36 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/19327/3
-- 
To view, visit https://review.coreboot.org/19327
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I96e74f49ea70e09cbac6f8af561de3e18fa7d260
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list