[coreboot-gerrit] Change in coreboot[master]: northbridge/haswell: clean up native graphics init code

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/19327 )

Change subject: northbridge/haswell: clean up native graphics init code
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/19327/1/src/northbridge/intel/haswell/gma.c
File src/northbridge/intel/haswell/gma.c:

Line 427: 	struct intel_dp dp;
> `struct intel_dp` is not needed any more.
going to assume you meant 'struct northbridge_intel_haswell_config' instead


Line 449: 		dp.graphics = (void *)((uintptr_t)dev->resource_list[1].base);
> Please test with `find_resource(dev, PCI_BASE_ADDRESS_2)` instead
this change produces a screen with rainbow-colored Gaussian noise and a hung boot


PS1, Line 451: 		dp.panel_power_down_delay = conf->gpu_panel_power_down_delay;
             : 		dp.panel_power_up_delay = conf->gpu_panel_power_up_delay;
             : 		dp.panel_power_cycle_delay = conf->gpu_panel_power_cycle_delay;
> No need for these any more since `dp` is not passed anywhere.
assume you mean 'conf' here again, since 'dp' is passed to gma_gfxinit()


-- 
To view, visit https://review.coreboot.org/19327
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96e74f49ea70e09cbac6f8af561de3e18fa7d260
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes