[coreboot-gerrit] Change in coreboot[master]: nb/intel/gm45: Hide some output behind DEBUG_RAM_SETUP

Martin Roth (Code Review) gerrit at coreboot.org
Sun Apr 16 20:05:51 CEST 2017


Martin Roth has posted comments on this change. ( https://review.coreboot.org/19318 )

Change subject: nb/intel/gm45: Hide some output behind DEBUG_RAM_SETUP
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/19318/2/src/northbridge/intel/gm45/gm45.h
File src/northbridge/intel/gm45/gm45.h:

PS2, Line 446: #define RAM_DEBUG (IS_ENABLED(CONFIG_DEBUG_RAM_SETUP) ? BIOS_DEBUG : BIOS_NEVER)
put into src/include/console/console.h instead?


https://review.coreboot.org/#/c/19318/2/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c
File src/northbridge/intel/gm45/raminit_receive_enable_calibration.c:

PS2, Line 263: BIOS_DEBUG
Should this be RAM_DEBUG too?


-- 
To view, visit https://review.coreboot.org/19318
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62a84ca662ee778b7c1deb71247f3b01a37858fa
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list