[coreboot-gerrit] Change in coreboot[master]: superio/ite/it8728f: Add fancontrol

[Tobias Diedrich (Code Review)]

Tobias Diedrich has posted comments on this change. ( https://review.coreboot.org/19293 )

Change subject: superio/ite/it8728f: Add fancontrol
......................................................................


Patch Set 2:

(1 comment)

> Theoretically, the user has the option, to change the start and full speed temperatures in the file `devicetree.cb`?
> Also, if somebody wanted to, that could also be made run-time configurable with the user option table in NVRAM, right?

Yeah, the thresholds can be changed in the devicetable and it could be made configurable.
On Linux you can configure it using the it87 hwmon driver, which allows you to change the pwm curve at runtime.

https://review.coreboot.org/#/c/19293/2/src/superio/ite/it8728f/it8728f_hwm.c
File src/superio/ite/it8728f/it8728f_hwm.c:

Line 87: 	pnp_write_index(port, HWM_FAN_PWM_SMOOTHING, conf->hwm_fan_pwm_smoothing);
> Please wrap this line.
Done


-- 
To view, visit https://review.coreboot.org/19293
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf0c8908ba5ad6ff552b8302bffc638aa9052941
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rudolf Marek <r.marek at assembler.cz>
Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes