[coreboot-gerrit] Change in coreboot[master]: drivers/storage: Add SD/MMC/eMMC driver based upon depthcharge

[Lee Leahy (Code Review)]

Lee Leahy has posted comments on this change. ( https://review.coreboot.org/19208 )

Change subject: drivers/storage: Add SD/MMC/eMMC driver based upon depthcharge
......................................................................


Patch Set 7:

(2 comments)

https://review.coreboot.org/#/c/19208/7/src/drivers/storage/Kconfig
File src/drivers/storage/Kconfig:

PS7, Line 18: 	default n
> Add a config that can be selected by a mainboard or maybe supported chipset
I believe that the above logic already has the behavior of only being included when specifically selected.  It should not show up by default during "make menuconfig" or the config questions for any platform.


https://review.coreboot.org/#/c/19208/7/src/drivers/storage/sd.c
File src/drivers/storage/sd.c:

PS7, Line 13:  * See file CREDITS for list of people who contributed to this
            :  * project.
> I hate seeing stuff like this.  Do we have any idea where this CREDITS file
Sorry, this came from the depthcharge code.


-- 
To view, visit https://review.coreboot.org/19208
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b5f9db1e27833e4ce4a97ad4f5ef3a46f64f2a2
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <reinauer at chromium.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes