[coreboot-gerrit] Change in coreboot[master]: binaryPI: use agesa/def_callouts.c

Marshall Dawson (Code Review) gerrit at coreboot.org
Fri Apr 14 23:12:13 CEST 2017


Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19274 )

Change subject: binaryPI: use agesa/def_callouts.c
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/19274/1/src/northbridge/amd/agesa/def_callouts.c
File src/northbridge/amd/agesa/def_callouts.c:

PS1, Line 28: ARCH_
CONFIG_ARCH_ROMSTAGE_X86_64 and CONFIG_ARCH_RAMSTAGE_X86_64?


PS1, Line 28:  
This came through as 0xc2, not as a space.


-- 
To view, visit https://review.coreboot.org/19274
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id20a49385aeb336461acd0bd186a4ab7f3fb95b8
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list