[coreboot-gerrit] Change in coreboot[master]: binaryPI: Disable CAR with empty stack
Marshall Dawson (Code Review)
gerrit at coreboot.org
Fri Apr 14 23:05:36 CEST 2017
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/18525 )
Change subject: binaryPI: Disable CAR with empty stack
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/18525/3/src/mainboard/amd/db-ft3b-lc/romstage.c
File src/mainboard/amd/db-ft3b-lc/romstage.c:
PS3, Line 79: post_code(0x41);
: AGESAWRAPPER(amdinitenv);
move into agesaboard_postcar?
https://review.coreboot.org/#/c/18525/3/src/mainboard/amd/gardenia/romstage.c
File src/mainboard/amd/gardenia/romstage.c:
PS3, Line 63: post_code(0x41);
: AGESAWRAPPER(amdinitenv);
move into agesaboard_postcar()?
--
To view, visit https://review.coreboot.org/18525
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bac098099c1caffea181356c63924f4b5a93b54
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Piotr Król <piotr.krol at 3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list