[coreboot-gerrit] Change in coreboot[master]: google/slippy: clean up NGI and move to libgfxinit

Matt DeVillier (Code Review) gerrit at coreboot.org
Fri Apr 14 21:57:06 CEST 2017


Hello build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/18824

to look at the new patch set (#4).

Change subject: google/slippy: clean up NGI and move to libgfxinit
......................................................................

google/slippy: clean up NGI and move to libgfxinit

- remove old, buggy NGI code from falco/peppy variants
- remove superfluous INTEL_DP/INTEL_DDI configs, since already
selected by northbridge/haswell
- always use libgfxinit when use native init config selected
- enable NGI/libgfxinit for all slippy variants

The reset of the old Haswell NGI code will be cleaned up in
a subsequent patchset.

Test: select MAINBOARD_DO_NATIVE_VGA_INIT, observe panel init
using SeaBIOS and Tianocore payloads on peppy, wolf variants

Change-Id: Id5727cad7f714ffa57e77e2a25505e3c28f55237
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/mainboard/google/slippy/Kconfig
M src/mainboard/google/slippy/variants/falco/Makefile.inc
D src/mainboard/google/slippy/variants/falco/gma.c
D src/mainboard/google/slippy/variants/falco/i915io.c
D src/mainboard/google/slippy/variants/falco/include/variant/mainboard.h
M src/mainboard/google/slippy/variants/peppy/Makefile.inc
D src/mainboard/google/slippy/variants/peppy/gma.c
D src/mainboard/google/slippy/variants/peppy/i915io.c
D src/mainboard/google/slippy/variants/peppy/include/variant/mainboard.h
9 files changed, 2 insertions(+), 832 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/18824/4
-- 
To view, visit https://review.coreboot.org/18824
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id5727cad7f714ffa57e77e2a25505e3c28f55237
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Ronald G. Minnich <rminnich at gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list