[coreboot-gerrit] Change in coreboot[master]: inteltool: Add missing `break` in `print_dmibar()`

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/18906 )

Change subject: inteltool: Add missing `break` in `print_dmibar()`
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://review.coreboot.org/#/c/18906/1/util/inteltool/pcie.c
File util/inteltool/pcie.c:

PS1, Line 319: break;
This will leave dmibar_phys undefined when it's used before.

I suspect omitting the break was intentional, but the author should have left a comment such as '/* fall thru */' to make the intention more clear.


-- 
To view, visit https://review.coreboot.org/18906
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12637b6bc18844a3bc47f06208df7fee7a4feb3b
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: David Hendricks <david.hendricks at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes