[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Set SERIRQ to continuous mode

Marc Jones (Code Review) gerrit at coreboot.org
Fri Apr 14 20:43:09 CEST 2017


Marc Jones has posted comments on this change. ( https://review.coreboot.org/19285 )

Change subject: google/kahlee: Set SERIRQ to continuous mode
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/19285/2//COMMIT_MSG
Commit Message:

PS2, Line 9: Kahlee EC
> For an “outside reviewer” it’d help to mention the name of the EC.
It isn't so much the specific EC part, but the software. Again this is all over in the chromium ec repo. Coreboot just deals with the interface.


PS2, Line 10: feature is available
> Is that done in the firmware?
yes


Line 11: 
> Could you please add what the result of your change is? What works now, wha
Done


-- 
To view, visit https://review.coreboot.org/19285
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie79acc7d3ae36d5c52248888b46245c2216467ec
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list