[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Add ASL for Elan touchpad

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/19288 )

Change subject: google/kahlee: Add ASL for Elan touchpad
......................................................................


Patch Set 2:

(1 comment)

> (4 comments)
 > 
 > Having C code to create this ASL dynamically would be nice. But I
 > guess, right now the device needs to fully work to meet some
 > deadlines.

This is done as the older chrome devices like rambi and auron. AMD hasn't received the auto-generated ASL code the Intel SOC chipsets have. It would be nice to port in the futue.

https://review.coreboot.org/#/c/19288/2/src/mainboard/google/kahlee/acpi/mainboard.asl
File src/mainboard/google/kahlee/acpi/mainboard.asl:

Line 53: 	Name (_S0W, 3)
> Hmm, looking again, no idea what the coding style is here. I guess we follo
I prefer the single mainboard file, so I did a cleanup patch with helps all the mainboard asl files.


-- 
To view, visit https://review.coreboot.org/19288
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3e762b05030002575b660a29b58612ab7c869a
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes