[coreboot-gerrit] Change in coreboot[master]: sb/amd/pi/hudson: Spell verb in comment with a space

Martin Roth (Code Review) gerrit at coreboot.org
Fri Apr 14 17:43:10 CEST 2017


Martin Roth has posted comments on this change. ( https://review.coreboot.org/19292 )

Change subject: sb/amd/pi/hudson: Spell verb in comment with a space
......................................................................


Patch Set 1:

If we're going to do this, why not do it across-the-board?
We see this same issue all over the codebase:

src/arch/x86/include/arch/interrupt.h:/* setup interrupt handlers for mainboard */
src/cpu/x86/lapic/secondary.S:  /* setup the data segment */
src/cpu/x86/sipi_vector.S:      /* setup the data segment */
src/device/oprom/yabel/pmm.c:   /* setup the PMM structure */
src/device/oprom/yabel/pmm.c:   /* setup stack for call to pmm_handleInt() */
src/include/cpu/intel/romstage.h: * torn down. The following values are pushed onto the stack to setup the
src/mainboard/intel/leafhill/romstage.c:        /* setup early gpio before memory */
src/soc/intel/fsp_baytrail/romstage/romstage.c: * Memory is setup and the stack is set by the FSP.
src/southbridge/amd/cs5536/early_setup.c:       /* setup LBAR for SMBus controller */

...

-- 
To view, visit https://review.coreboot.org/19292
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d0d8e2a20d15cbed30e98cf4468e9fb5dd0f1ad
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No



More information about the coreboot-gerrit mailing list