[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Enable ChromeEC

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/19166 )

Change subject: google/kahlee: Enable ChromeEC
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/19166/2/src/mainboard/google/kahlee/ec.c
File src/mainboard/google/kahlee/ec.c:

PS2, Line 52: #ifdef __PRE_RAM__
> Are the declarations guarded? If not, leave it. early_ec_init() will only b
yes, the deceleration is guarded and the function is lpc_wideio function is only in romstage. This could be moved, but is a bit of work in the hudson code, which could follow. I hesitate due to the stack dependencies that are already very long.


PS2, Line 64: %08x
> %08zx
Done


-- 
To view, visit https://review.coreboot.org/19166
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iac06b659e5274be2d7c3b34534e05adad3e3eb3d
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes