[coreboot-gerrit] Change in coreboot[master]: sb/amd/sb700: Disable LPC ROM mapping when SPI Flash is used

[Timothy Pearson (Code Review)]

Hello Felix Held, build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19280

to look at the new patch set (#3).

Change subject: sb/amd/sb700: Disable LPC ROM mapping when SPI Flash is used
......................................................................

sb/amd/sb700: Disable LPC ROM mapping when SPI Flash is used

Do not map LPC ROM into the system memory space when SPI Flash
is configured instead of an LPC ROM.

This resolves a long-standing hard boot hang issue on the ASUS
KGPE-D16 and related systems; in a nutshell, the incorrectly
mapped LPC ROM overrode low memory required by ramstage, causing
decompressed ramstage layout-dependent vectoring to romstage code
and subsequent execution of random sections of romstage.  Sometimes
these random sections of romstage reconfigured the hardware in such
a way that it could not access SPI Flash on the next boot attempt.

Change-Id: I115e5d834f0ca99c2d9dbb5b9b5badbea1d98574
Signed-off-by: Timothy Pearson <tpearson at raptorengineering.com>
---
M src/southbridge/amd/sb700/bootblock.c
1 file changed, 6 insertions(+), 8 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/19280/3
-- 
To view, visit https://review.coreboot.org/19280
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I115e5d834f0ca99c2d9dbb5b9b5badbea1d98574
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Timothy Pearson <tpearson at raptorengineering.com>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Raptor Engineering Automated Test Stand <noreply at raptorengineeringinc.com>
Gerrit-Reviewer: build bot (Jenkins)