[coreboot-gerrit] Change in coreboot[master]: sb/amd/sb700: Disable LPC ROM mapping when SPI Flash is used

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19280 )

Change subject: sb/amd/sb700: Disable LPC ROM mapping when SPI Flash is used
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/19280/2/src/southbridge/amd/sb700/bootblock.c
File src/southbridge/amd/sb700/bootblock.c:

PS2, Line 49: 		reg8 = pci_io_read_config8(dev, IO_MEM_PORT_DECODE_ENABLE_5);
You could move the read and writes outside of the if.


-- 
To view, visit https://review.coreboot.org/19280
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115e5d834f0ca99c2d9dbb5b9b5badbea1d98574
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Timothy Pearson <tpearson at raptorengineering.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Raptor Engineering Automated Test Stand <noreply at raptorengineeringinc.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes