[coreboot-gerrit] Change in coreboot[master]: arch/x86/acpi: Allow "transparent" ACPI device names

Timothy Pearson (Code Review) gerrit at coreboot.org
Fri Apr 14 00:12:25 CEST 2017


Timothy Pearson has uploaded a new change for review. ( https://review.coreboot.org/19281 )

Change subject: arch/x86/acpi: Allow "transparent" ACPI device names
......................................................................

arch/x86/acpi: Allow "transparent" ACPI device names

Certain devices, such as the northbridge on AMD Opteron systems,
do not require a node in the ACPI device path.  Allow such devices
to be passed over by the ACPI path generator if the device-specific
ACPI name function returns a zero-length (non-NULL) string.

Change-Id: Iffffc9a30b395b0bd6d60e411439a437e89f554e
Signed-off-by: Timothy Pearson <tpearson at raptorengineering.com>
---
M src/arch/x86/acpi_device.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/19281/1

diff --git a/src/arch/x86/acpi_device.c b/src/arch/x86/acpi_device.c
index f4f1c4c..2cb8445 100644
--- a/src/arch/x86/acpi_device.c
+++ b/src/arch/x86/acpi_device.c
@@ -113,7 +113,7 @@
 
 	/* Fill in the path from the root device */
 	next += snprintf(buf + next, buf_len - next, "%s%s",
-			 dev->path.type == DEVICE_PATH_ROOT ? "" : ".", name);
+			 (dev->path.type == DEVICE_PATH_ROOT || (strlen(name) == 0)) ? "" : ".", name);
 
 	return next;
 }

-- 
To view, visit https://review.coreboot.org/19281
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iffffc9a30b395b0bd6d60e411439a437e89f554e
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Timothy Pearson <tpearson at raptorengineering.com>



More information about the coreboot-gerrit mailing list