[coreboot-gerrit] Change in coreboot[master]: [WIP]mb/intel/dg43gt: Add mainboard

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19256 )

Change subject: [WIP]mb/intel/dg43gt: Add mainboard
......................................................................


Patch Set 5:

(4 comments)

> (3 comments)
 > 
 > As the payload executes fine, I am all for getting this in.

Ok. The suspend, power down issue can be fixed in a follow up commit (if a fix is found) or here if the required ICH10 patches don't get merged before I fix it.

https://review.coreboot.org/#/c/19256/5//COMMIT_MSG
Commit Message:

Line 17: 
> What board did you use a template?
The other x4x board: ga-g41m-es2l, but a lot of things were changed.


PS5, Line 19: * 2 DDR2 dimms per channel (tested with 1+2G in CH0 and 2+2G in CH1);
            : * SATA;
            : * Integrated GPU with option rom (extracted from a Gigabyte vendor
            :   bios);
            : * PCI;
            : * USB.
> I’d remove the `;` and `.` at the end of the items, as they are no sentence
OK


PS5, Line 28: 3 suspend, the board goes into S3 but is immediately woken (SuperIO
            :   or some other interrupt?)
Seems to be a deeper problem. It is not possible to power this board off either since it just reboots. only way to turn it off is pull the power.

SuperIO related?


PS5, Line 37: All the rest.
> What about the TPM?
There is no LPC header for TPM. Probably ME emulates a tpm but I have not tested with ME enabled.


-- 
To view, visit https://review.coreboot.org/19256
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If27280feb7cbf0a88f19fe6a63b1f6dbcf9b60f4
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes