[coreboot-gerrit] Change in coreboot[master]: mainboard/google/eve: Enable internal pull-down on USB_C{0, 1...

Duncan Laurie (Code Review) gerrit at coreboot.org
Thu Apr 13 12:06:16 CEST 2017


Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/19263 )

Change subject: mainboard/google/eve: Enable internal pull-down on USB_C{0,1}_DP_HPD
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19263/1//COMMIT_MSG
Commit Message:

PS1, Line 15: Verify that the kernel does not see a device present on DP when
            : the TCPC mux is in low power mode.
> With `xrandr`, or how do you check that?
We no longer run X in Chrome OS (I miss xrandr) so this was just by enabling kernel debugging.


-- 
To view, visit https://review.coreboot.org/19263
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie229f84871e9994467c0ab660cc7e271a51d9cbb
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list