[coreboot-gerrit] Change in coreboot[master]: google/eve: Disable Deep S3 in AC mode

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/19240 )

Change subject: google/eve: Disable Deep S3 in AC mode
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/19240/3//COMMIT_MSG
Commit Message:

PS3, Line 9: In order to support a standard "docked" config disable Deep S3 when
           : connected to AC power.  This allows USB devices to wake the device
           : from suspend if it is externally powered, but still retains the
           : lower power state when running on battery.
> I find this confusing, but I guess that’s the guide line for Chromium OS?
Ya its a product decision, I just do what I'm told :)

The registers are locked at runtime..


-- 
To view, visit https://review.coreboot.org/19240
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I670e39d42cdb5b80612206da899be82ef3b2cbf2
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes