[coreboot-gerrit] Change in coreboot[master]: mainboard/google/poppy: Enable internal pull-down on USB_C{0...

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/19243 )

Change subject: mainboard/google/poppy: Enable internal pull-down on USB_C{0,1}_DP_HPD
......................................................................


mainboard/google/poppy: Enable internal pull-down on USB_C{0,1}_DP_HPD

These lines act as inputs to both EC and AP. Thus, add internal
pull-downs to prevent them from floating.

BUG=b:35648530

Change-Id: I42326c810775d5449e99e52e81870970247ce335
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
Reviewed-on: https://review.coreboot.org/19243
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
M src/mainboard/google/poppy/gpio.h
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Aaron Durbin: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  build bot (Jenkins): Verified



diff --git a/src/mainboard/google/poppy/gpio.h b/src/mainboard/google/poppy/gpio.h
index be7a488..234d974 100644
--- a/src/mainboard/google/poppy/gpio.h
+++ b/src/mainboard/google/poppy/gpio.h
@@ -162,9 +162,9 @@
 					NF1), /* USB_C1_OC_ODL */
 /* USB2_OC2# */		PAD_CFG_GPO(GPP_E11, 0, DEEP), /* TOUCHSCREEN_RESET_L */
 /* USB2_OC3# */		PAD_CFG_NF(GPP_E12, NONE, DEEP, NF1), /* USB2_OC3_L */
-/* DDPB_HPD0 */		PAD_CFG_NF(GPP_E13, NONE, DEEP,
+/* DDPB_HPD0 */		PAD_CFG_NF(GPP_E13, 20K_PD, DEEP,
 					NF1), /* USB_C0_DP_HPD */
-/* DDPC_HPD1 */		PAD_CFG_NF(GPP_E14, NONE, DEEP,
+/* DDPC_HPD1 */		PAD_CFG_NF(GPP_E14, 20K_PD, DEEP,
 					NF1), /* USB_C1_DP_HPD */
 /* DDPD_HPD2 */		PAD_CFG_GPI(GPP_E15, 20K_PU, DEEP), /* SD_CD# */
 /* DDPE_HPD3 */		PAD_CFG_NC(GPP_E16), /* TP244 */

-- 
To view, visit https://review.coreboot.org/19243
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I42326c810775d5449e99e52e81870970247ce335
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: build bot (Jenkins)