[coreboot-gerrit] Change in coreboot[master]: google/slippy: fix internal mic for falco/wolf variants

[Matt DeVillier (Code Review)]

Matt DeVillier has uploaded a new change for review. ( https://review.coreboot.org/19262 )

Change subject: google/slippy: fix internal mic for falco/wolf variants
......................................................................

google/slippy: fix internal mic for falco/wolf variants

The HDA verb for falco/wolf's internal mic was wrong, preventing the mic
from working properly in Windows and macOS (the Linux driver overrides
the verb table so wasn't affected). Set the verb properly, to no
connector / no jack detect, in order to restore functionality

Also fix NID 0x1a being disabled twice for falco (instead of 0x1b
as well) and NID 0x1A not being disabled for wolf (as it is in the
original Chromium source)

Test: boot Windows and verify mic functional with Realtek drivers
on both falco and wolf

Change-Id: I9c343dda4762f0b1f814318c155e22c59d2da8db
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/mainboard/google/slippy/variants/falco/hda_verb.c
M src/mainboard/google/slippy/variants/wolf/hda_verb.c
2 files changed, 5 insertions(+), 9 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/19262/1

diff --git a/src/mainboard/google/slippy/variants/falco/hda_verb.c b/src/mainboard/google/slippy/variants/falco/hda_verb.c
index 790d501..3d12d8a 100644
--- a/src/mainboard/google/slippy/variants/falco/hda_verb.c
+++ b/src/mainboard/google/slippy/variants/falco/hda_verb.c
@@ -32,7 +32,7 @@
 	/* Pin Widget Verb Table */
 
 	/* Pin Complex (NID 0x12) DMIC - interior mobile lid */
-	AZALIA_PIN_CFG(0x0, 0x12, 0xb7a61010),
+	AZALIA_PIN_CFG(0x0, 0x12, 0xb7a60110),
 
 	/* Pin Complex (NID 0x14) SPKR-OUT PORTD */
 	// group 1, front left/right
@@ -58,7 +58,7 @@
 	AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
 
 	/* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */
-	AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
+	AZALIA_PIN_CFG(0x0, 0x1b, 0x411111f0),
 
 	/* Pin Complex (NID 0x1d) PCBeep */
 	// eapd low on ex-amp, laptop, custom enable
diff --git a/src/mainboard/google/slippy/variants/wolf/hda_verb.c b/src/mainboard/google/slippy/variants/wolf/hda_verb.c
index b043bf5..56fe320 100644
--- a/src/mainboard/google/slippy/variants/wolf/hda_verb.c
+++ b/src/mainboard/google/slippy/variants/wolf/hda_verb.c
@@ -37,7 +37,7 @@
 	/* Pin Widget Verb Table */
 
 	/* Pin Complex (NID 0x12) DMIC - interior mobile lid */
-	AZALIA_PIN_CFG(0x0, 0x12, 0xb7a61010),
+	AZALIA_PIN_CFG(0x0, 0x12, 0xb7a60110),
 
 	/* Pin Complex (NID 0x14) SPKR-OUT - Internal Speakers */
 	// group 1, cap 0
@@ -59,12 +59,8 @@
 	// connector, External left panel
 	AZALIA_PIN_CFG(0x0, 0x19, 0x03a11020),
 
-	/* Pin Complex (NID 0x1A) LINE1 - Internal Mic */
-	// group 1, cap 1
-	// no connector, no jack detect
-	// mic in, analog connection
-	// Fixed function, internal, Location N/A
-	AZALIA_PIN_CFG(0x0, 0x1a, 0x90a70111),
+	/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */
+	AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
 
 	/* Pin Complex (NID 0x1B) LINE2 - Disabled */
 	AZALIA_PIN_CFG(0x0, 0x1b, 0x411111f0),

-- 
To view, visit https://review.coreboot.org/19262
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c343dda4762f0b1f814318c155e22c59d2da8db
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>