[coreboot-gerrit] Change in coreboot[master]: amd/pi/00670F00: Add memmap file

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/18428 )

Change subject: amd/pi/00670F00: Add memmap file
......................................................................


Patch Set 7:

(6 comments)

https://review.coreboot.org/#/c/18428/7//COMMIT_MSG
Commit Message:

PS7, Line 7: amd/pi/stoney
> I'm curious why this is prefixed differently than the actual location of th
Done


https://review.coreboot.org/#/c/18428/7/src/northbridge/amd/pi/00670F00/memmap.c
File src/northbridge/amd/pi/00670F00/memmap.c:

PS7, Line 22: uint64_t
> Why is this a uint64_t return value? When you are returning something that 
Done


Line 30: 	LibAmdMsrRead(TOP_MEM2, &topmem2, &StdHeader);
> Use native MSRs. That way you get rid of that ugly uninitialized StdHeader 
Done


PS7, Line 48: uint64_t
> Might as well just make this size_t since it's always <= 4 GiB.
Done


Line 71: 	LibAmdMsrRead(TOP_MEM, &topmem, &StdHeader);
> dito
Done


https://review.coreboot.org/#/c/18428/7/src/northbridge/amd/pi/00670F00/northbridge.c
File src/northbridge/amd/pi/00670F00/northbridge.c:

PS7, Line 702: if(
> space between if and '('
Done


-- 
To view, visit https://review.coreboot.org/18428
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ddaa8359536081752fb8e47e49f4d5958416620
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes