[coreboot-gerrit] Change in coreboot[master]: mma : Make MMA blobs path SOC specific

Pratikkumar V Prajapati (Code Review) gerrit at coreboot.org
Wed Apr 12 20:11:51 CEST 2017


Pratikkumar V Prajapati has uploaded a new change for review. ( https://review.coreboot.org/19260 )

Change subject: mma : Make MMA blobs path SOC specific
......................................................................

mma : Make MMA blobs path SOC specific

MMA blobs are SOC specific (not board). So far MMA
is supported by big cores (SKL and KBL).

Change-Id: I922789a2a12d55360624dd6de15ab9f0bb5f0acf
Signed-off-by: Pratik Prajapati <pratikkumar.v.prajapati at intel.com>
---
M src/soc/intel/common/Kconfig
M src/soc/intel/common/Makefile.inc
2 files changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/19260/1

diff --git a/src/soc/intel/common/Kconfig b/src/soc/intel/common/Kconfig
index 919cb50..69aad5d 100644
--- a/src/soc/intel/common/Kconfig
+++ b/src/soc/intel/common/Kconfig
@@ -96,11 +96,6 @@
 	help
 	 Set this option to y to enable MMA (Memory Margin Analysis) support
 
-config MMA_BLOBS_PATH
-	string "Path to MMA blobs"
-	depends on MMA
-	default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/mma"
-
 config ADD_VBT_DATA_FILE
 	bool "Add a Video Bios Table (VBT) binary to CBFS"
 	help
diff --git a/src/soc/intel/common/Makefile.inc b/src/soc/intel/common/Makefile.inc
index acfd054..ebbd1a4 100644
--- a/src/soc/intel/common/Makefile.inc
+++ b/src/soc/intel/common/Makefile.inc
@@ -51,7 +51,13 @@
 endif
 
 ifeq ($(CONFIG_MMA),y)
-MMA_BLOBS_PATH = $(call strip_quotes,$(CONFIG_MMA_BLOBS_PATH))
+
+ifeq ($(CONFIG_SOC_INTEL_KABYLAKE),y)
+MMA_BLOBS_PATH = 3rdparty/blobs/soc/intel/kabylake/mma-blobs
+else
+MMA_BLOBS_PATH = 3rdparty/blobs/soc/intel/skylake/mma-blobs
+endif
+
 MMA_TEST_NAMES = $(notdir $(wildcard $(MMA_BLOBS_PATH)/tests/*))
 MMA_TEST_CONFIG_NAMES = $(notdir $(wildcard $(MMA_BLOBS_PATH)/configs/*))
 

-- 
To view, visit https://review.coreboot.org/19260
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I922789a2a12d55360624dd6de15ab9f0bb5f0acf
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>



More information about the coreboot-gerrit mailing list