[coreboot-gerrit] Change in coreboot[master]: mainboard/google/poppy: Enable internal pull-down on USB_C{0...

Furquan Shaikh (Code Review) gerrit at coreboot.org
Wed Apr 12 17:20:07 CEST 2017


Hello Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19243

to look at the new patch set (#2).

Change subject: mainboard/google/poppy: Enable internal pull-down on USB_C{0,1}_DP_HPD
......................................................................

mainboard/google/poppy: Enable internal pull-down on USB_C{0,1}_DP_HPD

These lines act as inputs to both EC and AP. Thus, add internal
pull-downs to prevent them from floating.

BUG=b:35648530

Change-Id: I42326c810775d5449e99e52e81870970247ce335
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/mainboard/google/poppy/gpio.h
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/19243/2
-- 
To view, visit https://review.coreboot.org/19243
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I42326c810775d5449e99e52e81870970247ce335
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list