[coreboot-gerrit] Change in coreboot[master]: mainboard/google/poppy: Add support for cr50 SPI TPM

Furquan Shaikh (Code Review) gerrit at coreboot.org
Tue Apr 11 21:27:38 CEST 2017


Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19238 )

Change subject: mainboard/google/poppy: Add support for cr50 SPI TPM
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/19238/2//COMMIT_MSG
Commit Message:

Line 12: 
> Why is it disabled by default?
This is just used for prototyping at this point.


https://review.coreboot.org/#/c/19238/2/src/mainboard/google/poppy/devicetree.cb
File src/mainboard/google/poppy/devicetree.cb:

PS2, Line 160: setup
> set up
Done


-- 
To view, visit https://review.coreboot.org/19238
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67793093c006c1325fc16f669a96126525f83243
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list