[coreboot-gerrit] Change in coreboot[master]: Documentation: Add technote/design doc for mitigating ReBAR ...

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19242 )

Change subject: Documentation: Add technote/design doc for mitigating ReBAR issue
......................................................................


Patch Set 1:

I think this looks really good overall for the specific issue it's addressing.

I'm not sure if it's a problem, but should this issue be generalized to say that all addresses that are loaded from outside of SMM need to be validated?

Should we also look to see if there's anything that can be moved out of SMM?  Our handlers are pretty thin already, but maybe some suspend/resume code can be moved out of SMM into ACPI for example?

-- 
To view, visit https://review.coreboot.org/19242
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icba9d7910dfd46f32a2c46b6fd064a9cc8e3beac
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No